heading-family should also default to mainfont #13475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
This stays closer to the Pandoc partial, and keeps logic there. It's slightly messier logic than treating but probably easier to maintain anyway. Will merge after #13470 |
gordonwoodhull
force-pushed
the
bugfix/13474
branch
from
d5110ff to
241e7bf
Compare
gordonwoodhull
force-pushed
the
bugfix/13474
branch
from
241e7bf to
f0f11da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
mainfonthas not been applied to the title since the implementation of typst brand yml in 1.6.This fix prefers
brand.typography.headings.familybut falls back tomainfontPerhaps we should follow the same precedence for
brand.typography.base.familyvsmainfonta few lines upquarto-cli/src/resources/formats/typst/pandoc/quarto/typst-show.typ
Lines 32 to 36 in d5110ff
Filing this made me wonder if we should handle
mainfontintypst-brand-yaml.luainstead, so filing this as draft and I think I prefer the next PR over this one.